TMI: external crates: lost and found

[tim]

I more-or-less finished external crate inference, at least in the local-crate case. I spent most of the time on that fighting with the borrow checker. To add the right directories into the session's list of additional library search path, I wrote some visitor code that looks at all the view_items in the crate. There are two types of view_items: extern mod directives and use directives. For this, I only care about extern mod directives.

The problem is that the visitor wants an @-closure, which can't use borrowed pointers, so accumulating a mutable vector of found extern mod thing seems... hard. I eventually gave up and worked around it with massive amounts of copying.

Once I get some tidy stuff cleaned up, and figure out the copy issue, I'll be ready to check that in and close #5681.

If I can finish #6407 (allowing extern mod directives to name remote packages) and #5683 (the test runner for rustpkg, which I've already started a rudimentary version of) tomorrow, then I'll be on-schedule so far. It might happen.

Comments

[nikomatsakis]

Regarding the borrow checker and the visitor: I think the visitor ought to be rewritten to a trait that uses `&mut self` functions. Short of that, an `@mut` value is probably what you wanted.

[tim]

Ah, I see. I started trying to do this and hit an ICE :-\ Not wanting to spend any more time yak-shaving, I'll see if I can hack around it.