TMI: So close, and yet...
Jul. 29th, 2013 06:45 pm![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
timThe pull request I landed on Friday, to make more kinds of refspecs work, landed.
I got the whole test suite to pass with my branch-that-took-forever that extends the extern mod syntax! But as I often do, I decided I should address the many NOTEs[*] I'd added to the code before submitting a pull request. There's always the tension between getting it right and getting it in the codebase, but this time I felt like there were too many embarrassing things, tests passing or not.
One of the things is that I changed the PkgId constructor (shockingly, that's for the type that represents package IDs) to take the current directory as an argument, in case you give it something like foo/bar/baz and that turns out to be a git repository and you want to get the version. Well, that was super silly of me, because as with everything in rustpkg, we want to search the RUST_PATH rather than searching in the current directory in some ad hoc way. So I fixed that (I always enjoy getting paid to undo my own work) and now all but one of the rustpkg tests work, but I'll leave that for tomorrow so I can have a victory early in the day.
I got the whole test suite to pass with my branch-that-took-forever that extends the extern mod syntax! But as I often do, I decided I should address the many NOTEs[*] I'd added to the code before submitting a pull request. There's always the tension between getting it right and getting it in the codebase, but this time I felt like there were too many embarrassing things, tests passing or not.
One of the things is that I changed the PkgId constructor (shockingly, that's for the type that represents package IDs) to take the current directory as an argument, in case you give it something like foo/bar/baz and that turns out to be a git repository and you want to get the version. Well, that was super silly of me, because as with everything in rustpkg, we want to search the RUST_PATH rather than searching in the current directory in some ad hoc way. So I fixed that (I always enjoy getting paid to undo my own work) and now all but one of the rustpkg tests work, but I'll leave that for tomorrow so I can have a victory early in the day.